Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 12:45, schrieb Stefan Hajnoczi: > On Thu, Oct 27, 2011 at 11:18 AM, Kevin Wolf wrote: >> Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: >>> Several block drivers set bs->read_only in .bdrv_open() but >>> block.c:bdrv_open_common() clobbers its value. Additionally, QED uses >>> bdrv_i

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 11:18 AM, Kevin Wolf wrote: > Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: >> Several block drivers set bs->read_only in .bdrv_open() but >> block.c:bdrv_open_common() clobbers its value.  Additionally, QED uses >> bdrv_is_read_only() in .bdrv_open() to decide whether to p

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 11:18 AM, Kevin Wolf wrote: > Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: >> Several block drivers set bs->read_only in .bdrv_open() but >> block.c:bdrv_open_common() clobbers its value.  Additionally, QED uses >> bdrv_is_read_only() in .bdrv_open() to decide whether to p

Re: [Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Kevin Wolf
Am 27.10.2011 11:54, schrieb Stefan Hajnoczi: > Several block drivers set bs->read_only in .bdrv_open() but > block.c:bdrv_open_common() clobbers its value. Additionally, QED uses > bdrv_is_read_only() in .bdrv_open() to decide whether to perform > consistency checks. > > The correct ordering is

[Qemu-devel] [PATCH 2/3] block: set bs->read_only before .bdrv_open()

2011-10-27 Thread Stefan Hajnoczi
Several block drivers set bs->read_only in .bdrv_open() but block.c:bdrv_open_common() clobbers its value. Additionally, QED uses bdrv_is_read_only() in .bdrv_open() to decide whether to perform consistency checks. The correct ordering is to initialize bs->read_only from the open flags before cal