Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Markus Armbruster
Chen Gang gang.chen.5...@gmail.com writes: 'ctx-fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- hw/9pfs/virtio-9p-local.c | 7 ---

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Chen Gang
On 03/03/2014 04:34 PM, Markus Armbruster wrote: Chen Gang gang.chen.5...@gmail.com writes: 'ctx-fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs. Signed-off-by: Chen Gang

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Markus Armbruster
Chen Gang gang.chen.5...@gmail.com writes: On 03/03/2014 04:34 PM, Markus Armbruster wrote: Chen Gang gang.chen.5...@gmail.com writes: 'ctx-fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs.

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Aneesh Kumar K.V
Chen Gang gang.chen.5...@gmail.com writes: On 03/03/2014 04:34 PM, Markus Armbruster wrote: Chen Gang gang.chen.5...@gmail.com writes: 'ctx-fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs.

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Aneesh Kumar K.V
Chen Gang gang.chen.5...@gmail.com writes: 'ctx-fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs. Signed-off-by: Chen Gang gang.chen.5...@gmail.com Will take care of Markus feedback.

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Chen Gang
On 03/03/2014 10:42 PM, Markus Armbruster wrote: Chen Gang gang.chen.5...@gmail.com writes: On 03/03/2014 04:34 PM, Markus Armbruster wrote: Turns a buffer overrun bug into a truncation bug. The next commit fixes truncation bugs including this one. Would be nice to spell this out in the

[Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-01 Thread Chen Gang
'ctx-fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- hw/9pfs/virtio-9p-local.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)