On 12/27/2011 11:30 PM, Peter Maydell wrote:
> On 27 December 2011 14:13, Avi Kivity wrote:
> > On 12/26/2011 04:58 PM, Peter Maydell wrote:
> >> > void sd_enable(SDState *sd, int enable)
> >> > {
> >> > -sd->enable = enable;
> >> > +sd->enable = enable ? true : false;
> >>
> >> This kin
On 27 December 2011 14:13, Avi Kivity wrote:
> On 12/26/2011 04:58 PM, Peter Maydell wrote:
>> > void sd_enable(SDState *sd, int enable)
>> > {
>> > - sd->enable = enable;
>> > + sd->enable = enable ? true : false;
>>
>> This kind of thing is why I don't like bool :-)
>
> /me leaps to bool
On 12/26/2011 04:58 PM, Peter Maydell wrote:
> >
> > void sd_enable(SDState *sd, int enable)
> > {
> > -sd->enable = enable;
> > +sd->enable = enable ? true : false;
>
> This kind of thing is why I don't like bool :-)
/me leaps to bool's defence:
sd->enable = enable should work just f
On 12/27/2011 05:27 PM, Andreas Färber wrote:
Am 26.12.2011 15:58, schrieb Peter Maydell:
diff --git a/hw/sd.c b/hw/sd.c
index 07eb263..2b489d3 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -81,22 +85,22 @@ struct SDState {
uint8_t sd_status[64];
uint32_t vhs;
int wp_switch;
-int *
Am 26.12.2011 15:58, schrieb Peter Maydell:
>> diff --git a/hw/sd.c b/hw/sd.c
>> index 07eb263..2b489d3 100644
>> --- a/hw/sd.c
>> +++ b/hw/sd.c
>> @@ -81,22 +85,22 @@ struct SDState {
>> uint8_t sd_status[64];
>> uint32_t vhs;
>> int wp_switch;
>> -int *wp_groups;
>> +uint8_t
On 12/26/2011 06:58 PM, Peter Maydell wrote:
On 26 December 2011 10:03, Mitsyanko Igor wrote:
We couldn't properly implement save/restore functionality of SD host controllers
states without SD card's state VMStateDescription implementation. This patch
updates SD card emulation to support save/l
On 26 December 2011 10:03, Mitsyanko Igor wrote:
> We couldn't properly implement save/restore functionality of SD host
> controllers
> states without SD card's state VMStateDescription implementation. This patch
> updates SD card emulation to support save/load of card's state.
>
> Signed-off-by:
We couldn't properly implement save/restore functionality of SD host controllers
states without SD card's state VMStateDescription implementation. This patch
updates SD card emulation to support save/load of card's state.
Signed-off-by: Mitsyanko Igor
---
hw/milkymist-memcard.c |2 +
hw/sd.c
