Re: [Qemu-devel] [PATCH 2/3] qemu-img: Use zero writes after source backing EOF

2019-04-24 Thread Max Reitz
On 18.04.19 20:59, Eric Blake wrote: > On 7/13/18 6:14 AM, Max Reitz wrote: >> Past the end of the source backing file, we memset() buf_old to zero, so >> it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite() >> then. >> >> Signed-off-by: Max Reitz >> --- >> qemu-img.c | 11 ++

Re: [Qemu-devel] [PATCH 2/3] qemu-img: Use zero writes after source backing EOF

2019-04-18 Thread Eric Blake
On 7/13/18 6:14 AM, Max Reitz wrote: > Past the end of the source backing file, we memset() buf_old to zero, so > it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite() > then. > > Signed-off-by: Max Reitz > --- > qemu-img.c | 11 +-- > 1 file changed, 9 insertions(+), 2 d

Re: [Qemu-devel] [PATCH 2/3] qemu-img: Use zero writes after source backing EOF

2018-07-21 Thread Max Reitz
On 2018-07-20 23:22, Eric Blake wrote: > On 07/13/2018 06:14 AM, Max Reitz wrote: >> Past the end of the source backing file, we memset() buf_old to zero, so >> it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite() >> then. >> >> Signed-off-by: Max Reitz >> --- >>   qemu-img.c | 11

Re: [Qemu-devel] [PATCH 2/3] qemu-img: Use zero writes after source backing EOF

2018-07-20 Thread Eric Blake
On 07/13/2018 06:14 AM, Max Reitz wrote: Past the end of the source backing file, we memset() buf_old to zero, so it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite() then. Signed-off-by: Max Reitz --- qemu-img.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions

[Qemu-devel] [PATCH 2/3] qemu-img: Use zero writes after source backing EOF

2018-07-13 Thread Max Reitz
Past the end of the source backing file, we memset() buf_old to zero, so it is clearly easy to use blk_pwrite_zeroes() instead of blk_pwrite() then. Signed-off-by: Max Reitz --- qemu-img.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c ind