[Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-17 Thread Stefan Hajnoczi
qtest_init() cannot use exec*p() to launch QEMU since the exec*p() functions take an argument array while qtest_init() takes char *extra_args. Therefore we execute /bin/sh -c and let the shell parse the argument string. This left /bin/sh as our child process and our child's child was QEMU. We st

Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > qtest_init() cannot use exec*p() to launch QEMU since the exec*p() > functions take an argument array while qtest_init() takes char > *extra_args. Therefore we execute /bin/sh -c and let the > shell parse the argument string. > > This left /bin/sh as our child process

Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-18 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 05:44:55PM +0100, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > qtest_init() cannot use exec*p() to launch QEMU since the exec*p() > > functions take an argument array while qtest_init() takes char > > *extra_args. Therefore we execute /bin/sh -c and let the >

Re: [Qemu-devel] [PATCH 2/3] qtest: make QEMU our direct child process

2014-02-18 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Feb 17, 2014 at 05:44:55PM +0100, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > qtest_init() cannot use exec*p() to launch QEMU since the exec*p() >> > functions take an argument array while qtest_init() takes char >> > *extra_args. Therefore we