Re: [Qemu-devel] [PATCH 2/3] reuse user_creatable_add_opts() instead of user_creatable_add() in monitor

2017-01-03 Thread Eric Blake
On 01/02/2017 09:44 AM, Igor Mammedov wrote: > Simplify code by dropping ~57LOC by merging user_creatable_add() > into user_creatable_add_opts() and using the later from monutor. s/monutor/monitor/ > Along with it allocate opts_visitor_new() once in user_creatable_add_opts(). -- Eric Blake eb

Re: [Qemu-devel] [PATCH 2/3] reuse user_creatable_add_opts() instead of user_creatable_add() in monitor

2017-01-03 Thread Eric Blake
On 01/02/2017 09:44 AM, Igor Mammedov wrote: > Simplify code by dropping ~57LOC by merging user_creatable_add() > into user_creatable_add_opts() and using the later from monutor. > Along with it allocate opts_visitor_new() once in user_creatable_add_opts(). > > As result we have one less API func

[Qemu-devel] [PATCH 2/3] reuse user_creatable_add_opts() instead of user_creatable_add() in monitor

2017-01-02 Thread Igor Mammedov
Simplify code by dropping ~57LOC by merging user_creatable_add() into user_creatable_add_opts() and using the later from monutor. Along with it allocate opts_visitor_new() once in user_creatable_add_opts(). As result we have one less API func and a more readable/simple user_creatable_add_opts() vs