Re: [Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 15:25:26 +0800 Dong Jia Shi wrote: > So, I only need to s/s/solicited for the new version of this one? Yes, that would be fine.

Re: [Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-28 Thread Dong Jia Shi
* Cornelia Huck [2017-07-27 13:22:59 +0200]: [...] > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c [...] > > @@ -2028,7 +2028,7 @@ void css_subch_assign(uint8_t cssid, uint8_t ssid, > > uint16_t schid, > > } > > } > > > > -void css_queue_crw(uint8_t rsc, uint8_t erc, int chain, uint16

Re: [Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-27 Thread Cornelia Huck
On Thu, 27 Jul 2017 03:54:17 +0200 Dong Jia Shi wrote: > A successful completion of rchp should signal a solicited channel path > initialized CRW (channel report word), while the current implementation > always generates an un-solicited one. Let's fix this. Sounds legit. > > Reported-by: Halil

[Qemu-devel] [PATCH 2/3] s390x/css: generate solicited crw for rchp completion signaling

2017-07-26 Thread Dong Jia Shi
A successful completion of rchp should signal a solicited channel path initialized CRW (channel report word), while the current implementation always generates an un-solicited one. Let's fix this. Reported-by: Halil Pasic Signed-off-by: Dong Jia Shi --- hw/s390x/css.c | 15 +