Eric Blake writes:
> On 11/23/2016 08:05 AM, Markus Armbruster wrote:
>
>> Same problem as in the previous patch, but here you replace it by
>> g_strdup_printf(), where the previous patch replaced it by manual
>> QObject construction,
>>
>> Manual QObject construction tends
Eric Blake writes:
> The qobject_from_jsonf() function implements a pseudo-printf
> language for creating a QObject; however, it is hard-coded to
> only parse a subset of formats understood by printf(). In
> particular, any use of a 64-bit integer works only if the
> system's
On 11/23/2016 08:05 AM, Markus Armbruster wrote:
> Same problem as in the previous patch, but here you replace it by
> g_strdup_printf(), where the previous patch replaced it by manual
> QObject construction,
>
> Manual QObject construction tends to be less readable.
Are there things we can do
On 23/11/2016 11:36, Eric Blake wrote:
> This is the key, look at:
> $ git grep -A2 strdup_printf tests/test-qga.c
>
> and you'll see that my change is no grosser than the rest of the file.
>
Oh well... I guess with a better commit message the patch is fine.
Paolo
signature.asc
On 11/23/2016 04:36 AM, Eric Blake wrote:
> I _really_ wish mingw would fix their headers (decide if 64-bit pid_t is
> really correct or not, and then make pid_t and getpid() match as well as
> supply id_t), but this isn't the forum to get that accomplished.
On 11/23/2016 03:23 AM, Paolo Bonzini wrote:
>
>
> - Original Message -
>> From: "Eric Blake"
>> To: qemu-devel@nongnu.org
>> Cc: programmingk...@gmail.com, arm...@redhat.com, pbonz...@redhat.com
>> Sent: Wednesday, November 23, 2016 5:16:27 AM
>> Subject: [PATCH 2/3]
- Original Message -
> From: "Eric Blake"
> To: qemu-devel@nongnu.org
> Cc: programmingk...@gmail.com, arm...@redhat.com, pbonz...@redhat.com
> Sent: Wednesday, November 23, 2016 5:16:27 AM
> Subject: [PATCH 2/3] test-qga: Avoid qobject_from_jsonf("%"PRId64)
>
> The
The qobject_from_jsonf() function implements a pseudo-printf
language for creating a QObject; however, it is hard-coded to
only parse a subset of formats understood by printf(). In
particular, any use of a 64-bit integer works only if the
system's definition of PRId64 matches what the parser