Re: [Qemu-devel] [PATCH 2/3] virtio pmem: remove memdev null check

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:53 +0530 Pankaj Gupta wrote: > Coverity reports that when we're assigning vi->size we handle the > "pmem->memdev is NULL" case; but we then pass it into > object_get_canonical_path(), which unconditionally dereferences it > and will crash if it is NULL. If this pointer

[Qemu-devel] [PATCH 2/3] virtio pmem: remove memdev null check

2019-07-12 Thread Pankaj Gupta
Coverity reports that when we're assigning vi->size we handle the "pmem->memdev is NULL" case; but we then pass it into object_get_canonical_path(), which unconditionally dereferences it and will crash if it is NULL. If this pointer can be NULL then we need to do something else here. We are remo