Currently, if we don't explicitly disable support for MSI installer
via --disable-guest-agent-msi, the configure variable that tracks
the flag, 'guest_agent_msi', never gets set unless one of the probes
fails. Subsequent code then treats this unset value the same as if it
were a "yes" value (via !=
Quoting Marc-André Lureau (2015-08-27 09:05:40)
> Hi
>
> On Thu, Aug 27, 2015 at 3:42 PM, Michael Roth
> wrote:
> > If we keep the $enabled != "no" logic all the way through, $enabled,
> > unless explicitly turned off or missing dependencies, will be
> > undefined when the configure options are
Hi
On Thu, Aug 27, 2015 at 3:42 PM, Michael Roth wrote:
> If we keep the $enabled != "no" logic all the way through, $enabled,
> unless explicitly turned off or missing dependencies, will be
> undefined when the configure options are summarized via:
>
> configure: qemu-ga: report MSI install su
Quoting Marc-André Lureau (2015-08-27 07:41:17)
> Hi
>
> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> wrote:
> > This makes it easier to report on whether or not MSI support was
> > enabled via probe by looking at the ./configure summary.
>
> Sorry I don't get what that really changes. Other
Hi
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
wrote:
> This makes it easier to report on whether or not MSI support was
> enabled via probe by looking at the ./configure summary.
Sorry I don't get what that really changes. Otherwise the patch looks fine.
--
Marc-André Lureau
Currently, if we don't explicitly disable support for MSI installer
via --disable-guest-agent-msi, the configure variable that tracks
the flag, 'guest_agent_msi', never gets set unless one of the probes
fails. Subsequent code then treats this unset value the same as if it
were a "yes" value (via !=
