Re: [Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1, 2, 3} device model

2016-11-14 Thread Andrew Jeffery
On Mon, 2016-11-14 at 08:14 +0100, Cédric Le Goater wrote: > > Given the starting point of the tmp105 code the patch looks okay, but I > > was a bit thrown by the use of the 'len' member as what I'd consider an > > index. For instance we reset len to zero in tmp421_event() after > > populating buf,

Re: [Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1, 2, 3} device model

2016-11-13 Thread Cédric Le Goater
On 05/23/2016 05:53 AM, Andrew Jeffery wrote: > Hi Cédric, > > On Fri, 2016-05-20 at 18:31 +0200, Cédric Le Goater wrote: >> Largely inspired by the TMP105 temperature sensor, this patch brings >> to Qemu a model for TMP42{1,2,3} temperature sensors. >> >> Specs can be found here : >> >> http

Re: [Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1, 2, 3} device model

2016-05-22 Thread Cédric Le Goater
On 05/23/2016 05:53 AM, Andrew Jeffery wrote: > Hi Cédric, > > On Fri, 2016-05-20 at 18:31 +0200, Cédric Le Goater wrote: >> Largely inspired by the TMP105 temperature sensor, this patch brings >> to Qemu a model for TMP42{1,2,3} temperature sensors. >> >> Specs can be found here : >> >> http

Re: [Qemu-devel] [PATCH 2/4] hw/misc: add a TMP42{1, 2, 3} device model

2016-05-22 Thread Andrew Jeffery
Hi Cédric, On Fri, 2016-05-20 at 18:31 +0200, Cédric Le Goater wrote: > Largely inspired by the TMP105 temperature sensor, this patch brings > to Qemu a model for TMP42{1,2,3} temperature sensors. > > Specs can be found here : > > http://www.ti.com/lit/gpn/tmp421 > > Signed-off-by: Cédric