Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"

2018-12-10 Thread Philippe Mathieu-Daudé
On 12/10/18 4:00 PM, Laszlo Ersek wrote: > On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: >> All the consumers of "smbios_ipmi.h" are located in hw/smbios/. > > I tried to verify this statement by grepping the tree for > "smbios_ipmi.h". There were zero hits. Please use the more precise > pathna

Re: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"

2018-12-10 Thread Laszlo Ersek
On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: > All the consumers of "smbios_ipmi.h" are located in hw/smbios/. I tried to verify this statement by grepping the tree for "smbios_ipmi.h". There were zero hits. Please use the more precise pathname "hw/smbios/ipmi.h". (I can't suggest just "ipmi.h

[Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"

2018-12-07 Thread Philippe Mathieu-Daudé
All the consumers of "smbios_ipmi.h" are located in hw/smbios/. There is no need to have this include publicly exposed, reduce the visibility by moving it in hw/smbios/. Signed-off-by: Philippe Mathieu-Daudé --- hw/smbios/smbios.c | 2 +- include/hw/smbios/ipmi.h