Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-12 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 10:34:35AM +0100, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Feb 06, 2019 at 02:23:29PM +0100, Juan Quintela wrote: > >> Libvirt don't want to expose (and explain it). And testing looks like > >> 128 is good for all use cases, so just drop it. > > > > One

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-12 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Feb 06, 2019 at 02:23:29PM +0100, Juan Quintela wrote: >> Libvirt don't want to expose (and explain it). And testing looks like >> 128 is good for all use cases, so just drop it. > > One significant concern inline... > >> >> Signed-off-by: Juan Quintela >> --

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-07 Thread Daniel P . Berrangé
On Wed, Feb 06, 2019 at 02:23:29PM +0100, Juan Quintela wrote: > Libvirt don't want to expose (and explain it). And testing looks like > 128 is good for all use cases, so just drop it. One significant concern inline... > > Signed-off-by: Juan Quintela > --- > hmp.c | 7 --

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-07 Thread Juan Quintela
Laurent Vivier wrote: > On 06/02/2019 18:58, Juan Quintela wrote: >> Laurent Vivier wrote: >>> On 06/02/2019 14:23, Juan Quintela wrote: Libvirt don't want to expose (and explain it). And testing looks like 128 is good for all use cases, so just drop it. Signed-off-by: Juan Q

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-06 Thread Laurent Vivier
On 06/02/2019 18:58, Juan Quintela wrote: > Laurent Vivier wrote: >> On 06/02/2019 14:23, Juan Quintela wrote: >>> Libvirt don't want to expose (and explain it). And testing looks like >>> 128 is good for all use cases, so just drop it. >>> >>> Signed-off-by: Juan Quintela >>> --- >>> hmp.c

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-06 Thread Juan Quintela
Laurent Vivier wrote: > On 06/02/2019 14:23, Juan Quintela wrote: >> Libvirt don't want to expose (and explain it). And testing looks like >> 128 is good for all use cases, so just drop it. >> >> Signed-off-by: Juan Quintela >> --- >> hmp.c | 7 --- >> migration/migration.

Re: [Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-06 Thread Laurent Vivier
On 06/02/2019 14:23, Juan Quintela wrote: > Libvirt don't want to expose (and explain it). And testing looks like > 128 is good for all use cases, so just drop it. > > Signed-off-by: Juan Quintela > --- > hmp.c | 7 --- > migration/migration.c | 30 -

[Qemu-devel] [PATCH 2/4] multifd: Drop x-multifd-page-count parameter

2019-02-06 Thread Juan Quintela
Libvirt don't want to expose (and explain it). And testing looks like 128 is good for all use cases, so just drop it. Signed-off-by: Juan Quintela --- hmp.c | 7 --- migration/migration.c | 30 -- migration/migration.h | 1 - migration/ram.c