Re: [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount

2010-09-17 Thread Kevin Wolf
Am 17.09.2010 19:06, schrieb Anthony Liguori: > On 09/17/2010 11:18 AM, Kevin Wolf wrote: >> Note that the flush is omitted intentionally in qcow2_free_clusters. If >> anything, we can leak clusters here if we lose the writes. >> >> Signed-off-by: Kevin Wolf >> > > Cluster leaking gets picked

Re: [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount

2010-09-17 Thread Anthony Liguori
On 09/17/2010 11:18 AM, Kevin Wolf wrote: Note that the flush is omitted intentionally in qcow2_free_clusters. If anything, we can leak clusters here if we lose the writes. Signed-off-by: Kevin Wolf Cluster leaking gets picked up by bdrv_check though, right? I think I've convinced myself

[Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount

2010-09-17 Thread Kevin Wolf
Note that the flush is omitted intentionally in qcow2_free_clusters. If anything, we can leak clusters here if we lose the writes. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/b