Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-22 Thread Aurelien Jarno
On Fri, Sep 14, 2012 at 07:18:17AM +0200, Stefan Weil wrote: > Am 14.09.2012 00:20, schrieb Richard Henderson: > >On 09/13/2012 03:03 PM, Peter Maydell wrote: > >>Hard to come up with a snappy name for "register which is the Nth > >>input argument if input args are in registers, but an arbitrary >

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Stefan Weil
Am 14.09.2012 00:20, schrieb Richard Henderson: On 09/13/2012 03:03 PM, Peter Maydell wrote: Hard to come up with a snappy name for "register which is the Nth input argument if input args are in registers, but an arbitrary temp reg otherwise, and which is in the forbidden list for the L constrai

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Richard Henderson
On 09/13/2012 03:03 PM, Peter Maydell wrote: > Hard to come up with a snappy name for "register which is the Nth > input argument if input args are in registers, but an arbitrary > temp reg otherwise, and which is in the forbidden list for the L > constraint"... I'm more than happy to let "registe

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Peter Maydell
On 13 September 2012 22:47, Aurelien Jarno wrote: > On Thu, Sep 13, 2012 at 02:30:36PM -0700, Richard Henderson wrote: >> On 09/13/2012 02:21 PM, Aurelien Jarno wrote: >> >> > #if TCG_TARGET_REG_BITS == 32 >> >> > tcg_out_ld(s, TCG_TYPE_PTR, TCG_AREG0, TCG_REG_ESP, >> >> > (A

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Aurelien Jarno
On Thu, Sep 13, 2012 at 02:30:36PM -0700, Richard Henderson wrote: > On 09/13/2012 02:21 PM, Aurelien Jarno wrote: > >> > #if TCG_TARGET_REG_BITS == 32 > >> > tcg_out_ld(s, TCG_TYPE_PTR, TCG_AREG0, TCG_REG_ESP, > >> > (ARRAY_SIZE(tcg_target_callee_save_regs) + 1) * 4); > >> >

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Richard Henderson
On 09/13/2012 02:21 PM, Aurelien Jarno wrote: >> > #if TCG_TARGET_REG_BITS == 32 >> > tcg_out_ld(s, TCG_TYPE_PTR, TCG_AREG0, TCG_REG_ESP, >> > (ARRAY_SIZE(tcg_target_callee_save_regs) + 1) * 4); >> > -tcg_out_ld(s, TCG_TYPE_PTR, tcg_target_call_iarg_regs[1], TCG_REG_ESP, >

Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Aurelien Jarno
On Thu, Sep 13, 2012 at 07:37:44PM +0200, Stefan Weil wrote: > While 64 bit hosts use the first three registers which are also used > as function input parameters, 32 bit hosts use TCG_REG_EAX and > TCG_REG_EDX which are not used in parameter passing. > > After defining new register macros for the

[Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers used in L constraint

2012-09-13 Thread Stefan Weil
While 64 bit hosts use the first three registers which are also used as function input parameters, 32 bit hosts use TCG_REG_EAX and TCG_REG_EDX which are not used in parameter passing. After defining new register macros for the registers used in L constraint, the patch replaces most occurrences of