Re: [Qemu-devel] [PATCH 2/4] virtio: add wrapper for saving/restoring virtqueue elements

2012-12-14 Thread Anthony Liguori
Paolo Bonzini writes: > Il 10/12/2012 15:29, Anthony Liguori ha scritto: >> Putting raw structures on the wire is bad news. Add a wrapper and use it. >> >> Note that in virtio-serial-bus, we were mapping both the in and out vectors >> as >> writable. This is a bug that is fixed by this change

Re: [Qemu-devel] [PATCH 2/4] virtio: add wrapper for saving/restoring virtqueue elements

2012-12-14 Thread Paolo Bonzini
Il 10/12/2012 15:29, Anthony Liguori ha scritto: > Putting raw structures on the wire is bad news. Add a wrapper and use it. > > Note that in virtio-serial-bus, we were mapping both the in and out vectors as > writable. This is a bug that is fixed by this change. I checked the revision > histor

[Qemu-devel] [PATCH 2/4] virtio: add wrapper for saving/restoring virtqueue elements

2012-12-10 Thread Anthony Liguori
Putting raw structures on the wire is bad news. Add a wrapper and use it. Note that in virtio-serial-bus, we were mapping both the in and out vectors as writable. This is a bug that is fixed by this change. I checked the revision history, it has been there since the code was first added and doe