Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-15 Thread Lei Li
On 05/15/2013 02:44 PM, Gerd Hoffmann wrote: On 05/15/13 08:05, Lei Li wrote: On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs)) { +vnc_led_state_change

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Gerd Hoffmann
On 05/15/13 08:05, Lei Li wrote: > On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: >> On 04/25/13 07:29, Lei Li wrote: >>> +/* Sending the current led state message to the client */ >>> +if (ledstate != current_led_state(vs)) { >>> +vnc_led_state_change(vs); >>> +} >> This check ne

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Laszlo Ersek
On 05/15/13 08:05, Lei Li wrote: > On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: >> On 04/25/13 07:29, Lei Li wrote: >>> +/* Sending the current led state message to the client */ >>> +if (ledstate != current_led_state(vs)) { >>> +vnc_led_state_change(vs); >>> +} >> This check ne

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Lei Li
On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs)) { +vnc_led_state_change(vs); +} This check never becomes true as the vnc modifier/led state just g

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Gerd Hoffmann
On 04/25/13 07:29, Lei Li wrote: > +/* Sending the current led state message to the client */ > +if (ledstate != current_led_state(vs)) { > +vnc_led_state_change(vs); > +} This check never becomes true as the vnc modifier/led state just got updated to match ledstate ... cheers

[Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c | 45 + ui/vnc.h |3 +++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..44189d7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6 +1522,42 @@ static void press_ke