On 01/11/2016 10:32 PM, Markus Armbruster wrote:
Cao jin writes:
[...]
Ok...will change the error msg to strerror(errno)
There's also error_setg_file_open(), not sure it fits here, but check it
out.
Thanks for reminding. Gerd Hoffmann has whole
patchset(http://lists.nongnu.org/archi
Cao jin writes:
> On 12/19/2015 05:18 AM, Markus Armbruster wrote:
>> One short remark in addition to Eduardo's review.
>>
>> Eduardo Habkost writes:
>>
> [...]
config_fd = open(path, O_RDWR);
if (config_fd < 0) {
+error_setg(errp, "No such device");
On 12/19/2015 05:18 AM, Markus Armbruster wrote:
One short remark in addition to Eduardo's review.
Eduardo Habkost writes:
[...]
config_fd = open(path, O_RDWR);
if (config_fd < 0) {
+error_setg(errp, "No such device");
return -ENODEV;
}
Can we come up
On 12/19/2015 02:37 AM, Eduardo Habkost wrote:
On Fri, Dec 18, 2015 at 07:03:49PM +0800, Cao jin wrote:
Signed-off-by: Cao jin
---
hw/pci-host/piix.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 715208b..
One short remark in addition to Eduardo's review.
Eduardo Habkost writes:
> On Fri, Dec 18, 2015 at 07:03:49PM +0800, Cao jin wrote:
>> Signed-off-by: Cao jin
>> ---
>> hw/pci-host/piix.c | 16 +---
>> 1 file changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/hw/pci-host/
On Fri, Dec 18, 2015 at 07:03:49PM +0800, Cao jin wrote:
> Signed-off-by: Cao jin
> ---
> hw/pci-host/piix.c | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 715208b..e3840f0 100644
> --- a/hw/pci-host/piix.
Signed-off-by: Cao jin
---
hw/pci-host/piix.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 715208b..e3840f0 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -761,7 +761,7 @@ static const IGDHostInfo i
