Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-10 Thread Aurelien Jarno
On 2016-08-09 22:12, Peter Maydell wrote: > On 9 August 2016 at 20:16, Aurelien Jarno wrote: > > On 2016-08-09 15:02, Pranith Kumar wrote: > >> Change the flag type to 'int' to fix the implicit conversion error. > >> > >> Suggested-by: Peter Maydell > >> Signed-off-by: Pranith Kumar > >> --- > >

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-10 Thread Paolo Bonzini
On 10/08/2016 12:37, Peter Maydell wrote: > On 10 August 2016 at 11:32, Richard Henderson wrote: >> On 08/10/2016 12:32 AM, Pranith Kumar wrote: >>> >>> typedef struct float_status { >>> +int float_exception_flags; >>> signed char float_detect_tininess; >>> signed char flo

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-10 Thread Peter Maydell
On 10 August 2016 at 11:32, Richard Henderson wrote: > On 08/10/2016 12:32 AM, Pranith Kumar wrote: >> >> typedef struct float_status { >> +int float_exception_flags; >> signed char float_detect_tininess; >> signed char float_rounding_mode; >> -signed char float_exceptio

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-10 Thread Richard Henderson
On 08/10/2016 12:32 AM, Pranith Kumar wrote: typedef struct float_status { +int float_exception_flags; signed char float_detect_tininess; signed char float_rounding_mode; -signed char float_exception_flags; Given that there are no flags outside 8 bits, why is this sup

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-09 Thread Peter Maydell
On 9 August 2016 at 20:16, Aurelien Jarno wrote: > On 2016-08-09 15:02, Pranith Kumar wrote: >> Change the flag type to 'int' to fix the implicit conversion error. >> >> Suggested-by: Peter Maydell >> Signed-off-by: Pranith Kumar >> --- >> fpu/softfloat-specialize.h | 2 +- >> include/fpu/softf

Re: [Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-09 Thread Aurelien Jarno
On 2016-08-09 15:02, Pranith Kumar wrote: > Change the flag type to 'int' to fix the implicit conversion error. > > Suggested-by: Peter Maydell > Signed-off-by: Pranith Kumar > --- > fpu/softfloat-specialize.h | 2 +- > include/fpu/softfloat.h| 4 ++-- > 2 files changed, 3 insertions(+), 3 d

[Qemu-devel] [PATCH 2/5] softfloat: Fix warn about implicit conversion from int to int8_t

2016-08-09 Thread Pranith Kumar
Change the flag type to 'int' to fix the implicit conversion error. Suggested-by: Peter Maydell Signed-off-by: Pranith Kumar --- fpu/softfloat-specialize.h | 2 +- include/fpu/softfloat.h| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fp