Re: [Qemu-devel] [PATCH 2/5] spapr: Refactor spapr_drc_detach()

2017-07-04 Thread David Gibson
On Thu, Jun 22, 2017 at 11:32:15AM +0200, Greg Kurz wrote: > On Wed, 21 Jun 2017 17:18:45 +0800 > David Gibson wrote: > > > This function has two unused parameters - remove them. > > > > It's ok for the d argument but I'm not sure about errp... Indeed it isn't used

Re: [Qemu-devel] [PATCH 2/5] spapr: Refactor spapr_drc_detach()

2017-06-22 Thread Greg Kurz
On Wed, 21 Jun 2017 17:18:45 +0800 David Gibson wrote: > This function has two unused parameters - remove them. > It's ok for the d argument but I'm not sure about errp... Indeed it isn't used in the current code, but looking at the paths below spapr_drc_detach(),

[Qemu-devel] [PATCH 2/5] spapr: Refactor spapr_drc_detach()

2017-06-21 Thread David Gibson
This function has two unused parameters - remove them. It also sets awaiting_release on all paths, except one. On that path setting it is harmless, since it will be immediately cleared by spapr_drc_release(). So factor it out of the if statements. Signed-off-by: David Gibson