Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread Aurelien Jarno
On 2017-06-15 15:10, David Hildenbrand wrote: > > >> A "sane" guest (e.g. Linux) will only use an instruction if the > >> corresponding stfl(e) bit is set. So in my opinion, this should be just > >> fine. If the bit is not set currently, the guest will not use it == dead > >> code. > > > > Not

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread David Hildenbrand
>> A "sane" guest (e.g. Linux) will only use an instruction if the >> corresponding stfl(e) bit is set. So in my opinion, this should be just >> fine. If the bit is not set currently, the guest will not use it == dead >> code. > > Not necessarily. Depending on the distribution, gcc and hence

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread Aurelien Jarno
On 2017-06-15 13:28, David Hildenbrand wrote: > On 15.06.2017 09:01, Aurelien Jarno wrote: > > On 2017-06-14 22:53, Richard Henderson wrote: > >> Signed-off-by: Richard Henderson > >> --- > >> target/s390x/translate.c | 8 > >> 1 file changed, 8 insertions(+) > >> > >>

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread David Hildenbrand
On 15.06.2017 09:01, Aurelien Jarno wrote: > On 2017-06-14 22:53, Richard Henderson wrote: >> Signed-off-by: Richard Henderson >> --- >> target/s390x/translate.c | 8 >> 1 file changed, 8 insertions(+) >> >> diff --git a/target/s390x/translate.c

Re: [Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-15 Thread Aurelien Jarno
On 2017-06-14 22:53, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/translate.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/target/s390x/translate.c b/target/s390x/translate.c > index af18ffb..48cee25 100644 > ---

[Qemu-devel] [PATCH 2/5] target/s390x: Enforce instruction features

2017-06-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index af18ffb..48cee25 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -55,6