Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-17 Thread Cornelia Huck
On Thu, 16 Jul 2015 19:22:21 +0200 Paolo Bonzini wrote: > > > On 16/07/2015 14:47, Michael S. Tsirkin wrote: > > I think for 2.4 it's a good idea to avoid enabling modern interface > > by default. Therefore, for 2.4 we can keep scsi enabled unless modern > > is requested by user. > > I agree.

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-16 Thread Paolo Bonzini
On 16/07/2015 14:47, Michael S. Tsirkin wrote: > I think for 2.4 it's a good idea to avoid enabling modern interface > by default. Therefore, for 2.4 we can keep scsi enabled unless modern > is requested by user. I agree. > I am also fine with just doing > > if (modern && scsi) >

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-16 Thread Michael S. Tsirkin
On Thu, Jul 16, 2015 at 02:37:12PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 21:51:32 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 05:38:53PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 17:39:18 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-16 Thread Cornelia Huck
On Wed, 15 Jul 2015 21:51:32 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 05:38:53PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 17:39:18 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > > > > On Wed, 15 Jul

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 05:38:53PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 17:39:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 17:11:57 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > > > > >

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 17:39:18 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 17:11:57 +0300 > > "Michael S. Tsirkin" wrote: > > > > > > > > > Fine, but revision is negotiated way before features are > > > > > > > probed

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 04:30:51PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 17:11:57 +0300 > "Michael S. Tsirkin" wrote: > > > > > > > Fine, but revision is negotiated way before features are > > > > > > probed so why does it make a practical difference? > > > > > > > > > > Legacy drive

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 17:11:57 +0300 "Michael S. Tsirkin" wrote: > > > > > Fine, but revision is negotiated way before features are > > > > > probed so why does it make a practical difference? > > > > > > > > Legacy drivers (that don't know about the set-revision command) will > > > > read feature

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 03:40:22PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 16:16:07 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 15:01:01 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed,

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 16:16:07 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 15:01:01 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > > > > On Wed, 15 Jul

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 02:43:51PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 15:01:01 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > > > On Wed, 15 Jul 2015 13:59:00 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue,

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 15:01:01 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > > On Wed, 15 Jul 2015 13:59:00 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > > > > Yes, and that

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2015 at 01:46:38PM +0200, Cornelia Huck wrote: > On Wed, 15 Jul 2015 13:59:00 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > > > Yes, and that's because as written, transitional devices must set > > > > ANY_LAYOUT, but

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Cornelia Huck
On Wed, 15 Jul 2015 13:59:00 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > > Yes, and that's because as written, transitional devices must set > > > ANY_LAYOUT, but that's incompatible with scsi. > > > > Hm, I had a patch before that dynam

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-15 Thread Michael S. Tsirkin
On Tue, Jul 14, 2015 at 07:43:44PM +0200, Cornelia Huck wrote: > > Yes, and that's because as written, transitional devices must set > > ANY_LAYOUT, but that's incompatible with scsi. > > Hm, I had a patch before that dynamically allowed different feature > sets for legacy or modern, not only a su

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-14 Thread Cornelia Huck
On Mon, 13 Jul 2015 18:35:53 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 15:36:00 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > > > > On Mon, 13 Jul

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote: > On Mon, 13 Jul 2015 15:36:00 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > > > On Mon, 13 Jul 2015 15:22:52 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon,

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 16:41, Cornelia Huck wrote: > On Mon, 13 Jul 2015 16:34:30 +0200 > Paolo Bonzini wrote: >> On 13/07/2015 15:20, Cornelia Huck wrote: >>> This would imply that any transitional device cannot offer scsi, >>> doesn't it? >>> >>> We have two layers interacting here: virtio-blk which ma

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Cornelia Huck
On Mon, 13 Jul 2015 16:34:30 +0200 Paolo Bonzini wrote: > > > On 13/07/2015 15:20, Cornelia Huck wrote: > > This would imply that any transitional device cannot offer scsi, > > doesn't it? > > > > We have two layers interacting here: virtio-blk which may or may not > > offer scsi support, and

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 15:20, Cornelia Huck wrote: > This would imply that any transitional device cannot offer scsi, > doesn't it? > > We have two layers interacting here: virtio-blk which may or may not > offer scsi support, and the transport layer which may or may not offer > VERSION_1 support. Failin

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Cornelia Huck
On Mon, 13 Jul 2015 15:36:00 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 15:22:52 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jul 13, 2015 at 01:51:56PM +0200, Cornelia Huck wrote: > > > > On Mon, 13 Jul

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > On Mon, 13 Jul 2015 15:22:52 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 13, 2015 at 01:51:56PM +0200, Cornelia Huck wrote: > > > On Mon, 13 Jul 2015 11:56:51 +0200 > > > Kevin Wolf wrote: > > > > > > > Am 13.07.2015 um

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Cornelia Huck
On Mon, 13 Jul 2015 15:22:52 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 01:51:56PM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 11:56:51 +0200 > > Kevin Wolf wrote: > > > > > Am 13.07.2015 um 11:00 hat Jason Wang geschrieben: > > > > > > > > > > > > On 07/13/2015 03:46

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 01:51:56PM +0200, Cornelia Huck wrote: > On Mon, 13 Jul 2015 11:56:51 +0200 > Kevin Wolf wrote: > > > Am 13.07.2015 um 11:00 hat Jason Wang geschrieben: > > > > > > > > > On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote: > > > > On Mon, Jul 13, 2015 at 01:46:48PM +0800,

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Cornelia Huck
On Mon, 13 Jul 2015 11:56:51 +0200 Kevin Wolf wrote: > Am 13.07.2015 um 11:00 hat Jason Wang geschrieben: > > > > > > On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote: > > > On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote: > > >> VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So d

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 05:00:51PM +0800, Jason Wang wrote: > > > On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote: > >> VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it. > >> > >> Cc: Stefan Hajnoczi > >> Cc: Kevin W

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Kevin Wolf
Am 13.07.2015 um 11:00 hat Jason Wang geschrieben: > > > On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote: > >> VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it. > >> > >> Cc: Stefan Hajnoczi > >> Cc: Kevin Wolf > >>

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Jason Wang
On 07/13/2015 03:46 PM, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote: >> VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it. >> >> Cc: Stefan Hajnoczi >> Cc: Kevin Wolf >> Cc: qemu-bl...@nongnu.org >> Signed-off-by: Jason Wang > Interestin

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 01:46:48PM +0800, Jason Wang wrote: > VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it. > > Cc: Stefan Hajnoczi > Cc: Kevin Wolf > Cc: qemu-bl...@nongnu.org > Signed-off-by: Jason Wang Interesting, I noticed we have a field scsi - see commit 1ba1f

[Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-12 Thread Jason Wang
VIRTIO_BLK_F_SCSI was no longer supported in 1.0. So disable it. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c