Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-11 Thread Igor Mammedov
On Tue, 5 Sep 2017 07:41:51 +0200 Thomas Huth wrote: > On 04.09.2017 16:00, Igor Mammedov wrote: > > Almost every user of cpu_generic_init() checks for > > returned NULL and then reports failure in a custom way > > and aborts process. > > Some users assume that call can't fail and don't check > >

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-11 Thread Igor Mammedov
On Mon, 4 Sep 2017 12:15:13 -0300 Philippe Mathieu-Daudé wrote: > On 09/04/2017 11:00 AM, Igor Mammedov wrote: > > Almost every user of cpu_generic_init() checks for > > returned NULL and then reports failure in a custom way > > and aborts process. > > Some users assume that call can't fail and d

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-11 Thread Igor Mammedov
On Tue, 5 Sep 2017 17:19:56 -0300 Eduardo Habkost wrote: > On Mon, Sep 04, 2017 at 04:00:58PM +0200, Igor Mammedov wrote: > > Almost every user of cpu_generic_init() checks for > > returned NULL and then reports failure in a custom way > > and aborts process. > > Some users assume that call can't

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-05 Thread Eduardo Habkost
On Mon, Sep 04, 2017 at 04:00:58PM +0200, Igor Mammedov wrote: > Almost every user of cpu_generic_init() checks for > returned NULL and then reports failure in a custom way > and aborts process. > Some users assume that call can't fail and don't check > for failure, though they should have checked

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-05 Thread Eduardo Habkost
On Tue, Sep 05, 2017 at 07:41:51AM +0200, Thomas Huth wrote: > On 04.09.2017 16:00, Igor Mammedov wrote: > > Almost every user of cpu_generic_init() checks for > > returned NULL and then reports failure in a custom way > > and aborts process. > > Some users assume that call can't fail and don't che

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-04 Thread Thomas Huth
On 04.09.2017 16:00, Igor Mammedov wrote: > Almost every user of cpu_generic_init() checks for > returned NULL and then reports failure in a custom way > and aborts process. > Some users assume that call can't fail and don't check > for failure, though they should have checked for it. > > In eithe

Re: [Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-04 Thread Philippe Mathieu-Daudé
On 09/04/2017 11:00 AM, Igor Mammedov wrote: Almost every user of cpu_generic_init() checks for returned NULL and then reports failure in a custom way and aborts process. Some users assume that call can't fail and don't check for failure, though they should have checked for it. In either cases c

[Qemu-devel] [PATCH 2/6] cpu: make cpu_generic_init() abort QEMU on error

2017-09-04 Thread Igor Mammedov
Almost every user of cpu_generic_init() checks for returned NULL and then reports failure in a custom way and aborts process. Some users assume that call can't fail and don't check for failure, though they should have checked for it. In either cases cpu_generic_init() failure is fatal, so instead