Re: [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes

2015-03-17 Thread Gerd Hoffmann
Hi, > Another possibility is to leave the write_ops in there, but turn them > into no-ops. That is the safe choice. Just have a write function with /* nothing, write support removed in qemu 2.4+ */. That is basically the same we have today (writes are ignored), but a bit more efficient becaus

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes

2015-03-16 Thread Gabriel L. Somlo
On Mon, Mar 16, 2015 at 06:02:45PM +0100, Laszlo Ersek wrote: > On 03/16/15 15:15, Gabriel L. Somlo wrote: > > The fw_cfg device allowed guest-side data writes to overwrite the > > selected entry in place, without allowing modification to the size > > of the entry, and with the ability to invoke a

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes

2015-03-16 Thread Laszlo Ersek
On 03/16/15 15:15, Gabriel L. Somlo wrote: > The fw_cfg device allowed guest-side data writes to overwrite the > selected entry in place, without allowing modification to the size > of the entry, and with the ability to invoke a callback each time > the entry was overwritten completely. > > To dat

[Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes

2015-03-16 Thread Gabriel L. Somlo
The fw_cfg device allowed guest-side data writes to overwrite the selected entry in place, without allowing modification to the size of the entry, and with the ability to invoke a callback each time the entry was overwritten completely. To date, we are not aware of any use case which relies on the