Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-08 Thread Juan Quintela
Peter Xu wrote: > On Thu, Jun 08, 2017 at 01:12:29PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote: ... >> >> Yeap. I *thought* that there was a way to test/set thing >> programatically also so I didn't have to create/export t

Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-08 Thread Peter Xu
On Thu, Jun 08, 2017 at 01:12:29PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote: > > >> > +/* This is only used if MigrationState.store_global_state is set. */ > >> > static GlobalState global_state; > >> > > >> > int global_s

Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-08 Thread Juan Quintela
Peter Xu wrote: > On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote: >> > +/* This is only used if MigrationState.store_global_state is set. */ >> > static GlobalState global_state; >> > >> > int global_state_store(void) >> > @@ -179,7 +179,7 @@ static RunState global_state_get_ru

Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-08 Thread Peter Xu
On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Put it into MigrationState then we can use the properties to specify > > whether to enable storing global state. > > > > Signed-off-by: Peter Xu > > --- > > include/migration/migration.h | 6 ++ > > migrati

Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-07 Thread Juan Quintela
Peter Xu wrote: > Put it into MigrationState then we can use the properties to specify > whether to enable storing global state. > > Signed-off-by: Peter Xu > --- > include/migration/migration.h | 6 ++ > migration/migration.c | 21 + > 2 files changed, 23 insert

[Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

2017-06-06 Thread Peter Xu
Put it into MigrationState then we can use the properties to specify whether to enable storing global state. Signed-off-by: Peter Xu --- include/migration/migration.h | 6 ++ migration/migration.c | 21 + 2 files changed, 23 insertions(+), 4 deletions(-) diff --