Re: [Qemu-devel] [PATCH 2/6] target/arm: Fix SVE system register access checks

2018-06-29 Thread Laurent Desnogues
Hello, On Fri, Jun 29, 2018 at 2:15 AM, Richard Henderson wrote: > Leave ARM_CP_SVE, removing ARM_CP_FPU; the sve_access_check > produced by the flag already includes fp_access_check. If > we also check ARM_CP_FPU the double fp_access_check asserts. > > Reported-by: Laurent Desnogues > Signed-o

Re: [Qemu-devel] [PATCH 2/6] target/arm: Fix SVE system register access checks

2018-06-29 Thread Peter Maydell
On 29 June 2018 at 01:15, Richard Henderson wrote: > Leave ARM_CP_SVE, removing ARM_CP_FPU; the sve_access_check > produced by the flag already includes fp_access_check. If > we also check ARM_CP_FPU the double fp_access_check asserts. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH 2/6] target/arm: Fix SVE system register access checks

2018-06-28 Thread Philippe Mathieu-Daudé
On 06/28/2018 09:15 PM, Richard Henderson wrote: > Leave ARM_CP_SVE, removing ARM_CP_FPU; the sve_access_check > produced by the flag already includes fp_access_check. If > we also check ARM_CP_FPU the double fp_access_check asserts. Maybe we can surround this assert() with #ifdef DEBUG_DISAS...

[Qemu-devel] [PATCH 2/6] target/arm: Fix SVE system register access checks

2018-06-28 Thread Richard Henderson
Leave ARM_CP_SVE, removing ARM_CP_FPU; the sve_access_check produced by the flag already includes fp_access_check. If we also check ARM_CP_FPU the double fp_access_check asserts. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/helper.c| 8 target