Re: [Qemu-devel] [PATCH 2/6] tcg: Always define all of the TCGOpcode enum members.

2011-08-23 Thread Richard Henderson
On 08/23/2011 10:11 AM, Peter Maydell wrote: > A compile-time check that the tcg target has #defined all the > TCG_TARGET_HAS_foo to 0/1 and not left any undefined might be > useful? That compile-time check is the uses in tcg-op.h. If they're not defined you'll get undefined symbol errors in that

Re: [Qemu-devel] [PATCH 2/6] tcg: Always define all of the TCGOpcode enum members.

2011-08-23 Thread Peter Maydell
On 17 August 2011 22:11, Richard Henderson wrote: > By always defining these symbols, we can eliminate a lot of ifdefs. > > To allow this to be checked reliably, the semantics of the > TCG_TARGET_HAS_* macros must be changed from def/undef to true/false. > This allows even more ifdefs to be remove