Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-15 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 08:55:08PM +0100, Vasilis Liaskovitis wrote: On Wed, Mar 14, 2012 at 05:23:24PM +0200, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi, On a different note, are your going to continue working on your memory hot

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Vasilis Liaskovitis
On Wed, Mar 14, 2012 at 05:23:24PM +0200, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi, On a different note, are your going to continue working on your memory hot plug series? I am going to look at it now. The memory hotplug patch from

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Igor Mammedov
On 03/14/2012 08:59 AM, Lai Jiangshan wrote: On 03/13/2012 07:04 PM, Andreas Färber wrote: Am 13.03.2012 10:32, schrieb Lai Jiangshan: On 02/16/2012 08:51 PM, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Vasilis Liaskovitis
Hi, On Wed, Mar 14, 2012 at 09:37:18AM +0100, Igor Mammedov wrote: On 03/14/2012 08:59 AM, Lai Jiangshan wrote: not accepted, so I don't know how to take part in. As I see it, there is not much to do from cpu hot-plug perspective. It's just a matter of adaptation QOM-ified cpus for usage

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi, On Wed, Mar 14, 2012 at 09:37:18AM +0100, Igor Mammedov wrote: On 03/14/2012 08:59 AM, Lai Jiangshan wrote: not accepted, so I don't know how to take part in. As I see it, there is not much to do from cpu

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Anthony Liguori
On 03/14/2012 10:23 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi, On Wed, Mar 14, 2012 at 09:37:18AM +0100, Igor Mammedov wrote: On 03/14/2012 08:59 AM, Lai Jiangshan wrote: not accepted, so I don't know how to take part in. As I see it,

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 10:32:37AM -0500, Anthony Liguori wrote: On 03/14/2012 10:23 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi, On Wed, Mar 14, 2012 at 09:37:18AM +0100, Igor Mammedov wrote: On 03/14/2012 08:59 AM, Lai Jiangshan wrote:

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Anthony Liguori
On 03/14/2012 10:35 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 10:32:37AM -0500, Anthony Liguori wrote: On 03/14/2012 10:23 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi, On Wed, Mar 14, 2012 at 09:37:18AM +0100, Igor Mammedov wrote: On

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 10:42:50AM -0500, Anthony Liguori wrote: On 03/14/2012 10:35 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 10:32:37AM -0500, Anthony Liguori wrote: On 03/14/2012 10:23 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 02:49:59PM +0100, Vasilis Liaskovitis wrote: Hi,

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Anthony Liguori
On 03/14/2012 10:54 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 10:42:50AM -0500, Anthony Liguori wrote: There's still a few places in QEMU that assume that qemu_ram_get_ptr() returns a pointer that's good indefinitely. We also don't have a mechanism to revoke cpu_physical_map() pointers.

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-14 Thread Gleb Natapov
On Wed, Mar 14, 2012 at 10:57:15AM -0500, Anthony Liguori wrote: On 03/14/2012 10:54 AM, Gleb Natapov wrote: On Wed, Mar 14, 2012 at 10:42:50AM -0500, Anthony Liguori wrote: There's still a few places in QEMU that assume that qemu_ram_get_ptr() returns a pointer that's good indefinitely.

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-13 Thread Lai Jiangshan
On 02/16/2012 08:51 PM, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +.qdev.reset = cpu_device_reset, +.init =

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-03-13 Thread Andreas Färber
Am 13.03.2012 10:32, schrieb Lai Jiangshan: On 02/16/2012 08:51 PM, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-17 Thread Igor Mammedov
On 02/16/2012 05:09 PM, Andreas Färber wrote: Am 16.02.2012 00:16, schrieb Igor Mammedov: Convert pc cpu to qdev device that is attached to icc bus, later hot-plug ability of icc bus will allow to implement cpu hot-plug. Signed-off-by: Igor Mammedovimamm...@redhat.com This conflicts with CPU

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-17 Thread Andreas Färber
Am 17.02.2012 18:16, schrieb Igor Mammedov: On 02/16/2012 05:09 PM, Andreas Färber wrote: We should have a single code path through which we instantiate CPUs, currently: cpu_$arch_init(const char *cpu_model) With my series completed, this would return an X86CPU object. Depending on our

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: Convert pc cpu to qdev device that is attached to icc bus, later hot-plug ability of icc bus will allow to implement cpu hot-plug. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pc.c | 62

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +.qdev.reset = cpu_device_reset, +.init = cpu_device_init, +.qdev.props = (Property[]) { +DEFINE_PROP_STRING(model, CPUPC,

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/15/2012 05:16 PM, Igor Mammedov wrote: Convert pc cpu to qdev device that is attached to icc bus, later hot-plug ability of icc bus will allow to implement cpu hot-plug. Signed-off-by: Igor Mammedovimamm...@redhat.com Obviously, this needs to go to QOM, but also, this is a shallow

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +.qdev.reset = cpu_device_reset, +.init = cpu_device_init, +.qdev.props = (Property[]) { +

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:51, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +.qdev.reset = cpu_device_reset, +.init =

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Andreas Färber
Am 16.02.2012 00:16, schrieb Igor Mammedov: Convert pc cpu to qdev device that is attached to icc bus, later hot-plug ability of icc bus will allow to implement cpu hot-plug. Signed-off-by: Igor Mammedov imamm...@redhat.com This conflicts with CPU QOM'ification across targets (and no longer

Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:54 AM, Jan Kiszka wrote: On 2012-02-16 13:51, Anthony Liguori wrote: On 02/16/2012 06:01 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: +static ICCBusDeviceInfo cpu_device_info = { +.qdev.name = cpu-pc, +.qdev.size = sizeof(CPUPC), +.qdev.reset =

[Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

2012-02-15 Thread Igor Mammedov
Convert pc cpu to qdev device that is attached to icc bus, later hot-plug ability of icc bus will allow to implement cpu hot-plug. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pc.c | 62 +++-- target-i386/cpu.h|1 +