Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-30 Thread Alon Levy
On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: > On 01/11/2011 02:42 AM, Alon Levy wrote: > >diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h > >new file mode 100644 > >index 000..9ff1295 > >--- /dev/null > >+++ b/libcacard/vscard_common.h > > This file (and

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-28 Thread Anthony Liguori
On 01/27/2011 03:13 PM, Alon Levy wrote: This is not ipv6 friendly. Two strings would be a better choice. A string for host makes sense, why for port? isn't a 32 bit port enough? For an protocol, an integer is probably fine. For an API, a string is nice to allow service names too.

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-27 Thread Alon Levy
On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: > On 01/11/2011 02:42 AM, Alon Levy wrote: > >diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h > >new file mode 100644 > >index 000..9ff1295 > >--- /dev/null > >+++ b/libcacard/vscard_common.h > > This file (and

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Alon Levy
On Tue, Jan 25, 2011 at 10:24:53AM -0600, Anthony Liguori wrote: > On 01/25/2011 10:21 AM, Alon Levy wrote: > >On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: > >>On 01/11/2011 02:42 AM, Alon Levy wrote: > >>>diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h > >>>n

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Anthony Liguori
On 01/25/2011 10:21 AM, Alon Levy wrote: On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: On 01/11/2011 02:42 AM, Alon Levy wrote: diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h new file mode 100644 index 000..9ff1295 --- /dev/null +++ b/libcaca

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Alon Levy
On Tue, Jan 25, 2011 at 08:17:32AM -0600, Anthony Liguori wrote: > On 01/11/2011 02:42 AM, Alon Levy wrote: > >diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h > >new file mode 100644 > >index 000..9ff1295 > >--- /dev/null > >+++ b/libcacard/vscard_common.h > > This file (and

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Anthony Liguori
On 01/11/2011 02:42 AM, Alon Levy wrote: diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h new file mode 100644 index 000..9ff1295 --- /dev/null +++ b/libcacard/vscard_common.h This file (and the .c file) need a coding style pass to fixup comments and the use of _ as a

[Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-11 Thread Alon Levy
The passthru ccid card is a device sitting on the usb-ccid bus and using a chardevice to communicate with a remote device using the VSCard protocol defined in libcacard/vscard_common.h Usage docs available in following patch in docs/ccid.txt Signed-off-by: Alon Levy --- Makefile.objs