Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Jan Kiszka
On 2011-06-08 14:33, Jan Kiszka wrote: > On 2011-06-08 14:28, Gerd Hoffmann wrote: >>> @@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) >>> static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, >>> uint32_t val, int len) >>> { >>>

Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Jan Kiszka
On 2011-06-08 14:28, Gerd Hoffmann wrote: >> @@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) >> static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, >> uint32_t val, int len) >> { >> -IntelHDAState *d = DO_UPCAST(IntelHDASta

Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Gerd Hoffmann
@@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, uint32_t val, int len) { -IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci); - pci_default_write_config(pci, add

[Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Jan Kiszka
Terminate msi/msix_write_config early if support is not enabled. This allows to remove checks at the caller site if MSI is optional. CC: Gerd Hoffmann Signed-off-by: Jan Kiszka --- hw/intel-hda.c |6 +- hw/msi.c |3 ++- hw/msix.c |2 +- 3 files changed, 4 insertions(+