Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-28 Thread Stafford Horne
On Thu, Apr 28, 2022 at 01:16:51PM +0200, Jason A. Donenfeld wrote: > Hey again, > > On Thu, Apr 28, 2022 at 02:04:29AM +0200, Jason A. Donenfeld wrote: > > By the way, would this also help the reboot case? That's > > `reboot(RB_AUTOBOOT);`, which does: > > > > machine_restart() -> > > do_kerne

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-28 Thread Jason A. Donenfeld
Hey again, On Thu, Apr 28, 2022 at 02:04:29AM +0200, Jason A. Donenfeld wrote: > By the way, would this also help the reboot case? That's > `reboot(RB_AUTOBOOT);`, which does: > > machine_restart() -> > do_kernel_restart() -> > atomic_notifier_chain_register(&restart_handler_list, nb) -> >

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-28 Thread Peter Maydell
On Wed, 27 Apr 2022 at 23:27, Stafford Horne wrote: > Yes, this is what was brought up before. At that time semihosting was > mentioned > and I tried to understand what it was but didn't really understand it as a > general > concept. Is this something arm specific? QEMU uses "semihosting" for

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-27 Thread Jason A. Donenfeld
Hi Stafford, On Thu, Apr 28, 2022 at 06:48:27AM +0900, Stafford Horne wrote: > On Wed, Apr 27, 2022 at 07:47:33PM +0100, Peter Maydell wrote: > > On Wed, 27 Apr 2022 at 18:46, Jason A. Donenfeld wrote: > > > > > > Hey Stafford, > > > > > > On Mon, Apr 17, 2017 at 08:23:51AM +0900, Stafford Horne

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-27 Thread Stafford Horne
On Wed, Apr 27, 2022 at 07:47:33PM +0100, Peter Maydell wrote: > On Wed, 27 Apr 2022 at 18:46, Jason A. Donenfeld wrote: > > > > Hey Stafford, > > > > On Mon, Apr 17, 2017 at 08:23:51AM +0900, Stafford Horne wrote: > > > In openrisc simulators we use hooks like 'l.nop 1' to cause the > > > simulat

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-27 Thread Peter Maydell
On Wed, 27 Apr 2022 at 18:46, Jason A. Donenfeld wrote: > > Hey Stafford, > > On Mon, Apr 17, 2017 at 08:23:51AM +0900, Stafford Horne wrote: > > In openrisc simulators we use hooks like 'l.nop 1' to cause the > > simulator to exit. Implement that for qemu too. > > > > Reported-by: Waldemar Brodk

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2022-04-27 Thread Jason A. Donenfeld
Hey Stafford, On Mon, Apr 17, 2017 at 08:23:51AM +0900, Stafford Horne wrote: > In openrisc simulators we use hooks like 'l.nop 1' to cause the > simulator to exit. Implement that for qemu too. > > Reported-by: Waldemar Brodkorb > Signed-off-by: Stafford Horne I'm curious as to why this never

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2017-04-22 Thread Richard Henderson
On 04/22/2017 12:09 PM, Stafford Horne wrote: I discussed a bit on #qemu and Alexander Graf suggested to properly define shutdown semantics for openrisc. Some examples were shown from ppc, s390 and arm. Yes, properly defining this in the spec goes a long way toward fixing the underlying proble

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2017-04-22 Thread Stafford Horne
On Tue, Apr 18, 2017 at 11:20:55PM +0900, Stafford Horne wrote: > On Tue, Apr 18, 2017 at 12:52:52AM -0700, Richard Henderson wrote: > > On 04/16/2017 04:23 PM, Stafford Horne wrote: > > > In openrisc simulators we use hooks like 'l.nop 1' to cause the > > > simulator to exit. Implement that for q

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2017-04-18 Thread Stafford Horne
On Tue, Apr 18, 2017 at 12:52:52AM -0700, Richard Henderson wrote: > On 04/16/2017 04:23 PM, Stafford Horne wrote: > > In openrisc simulators we use hooks like 'l.nop 1' to cause the > > simulator to exit. Implement that for qemu too. > > > > Reported-by: Waldemar Brodkorb > > Signed-off-by: Sta

Re: [Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2017-04-18 Thread Richard Henderson
On 04/16/2017 04:23 PM, Stafford Horne wrote: In openrisc simulators we use hooks like 'l.nop 1' to cause the simulator to exit. Implement that for qemu too. Reported-by: Waldemar Brodkorb Signed-off-by: Stafford Horne As I said the first time this was posted: This is horrible. If you want

[Qemu-devel] [PATCH 2/7] target/openrisc: add shutdown logic

2017-04-16 Thread Stafford Horne
In openrisc simulators we use hooks like 'l.nop 1' to cause the simulator to exit. Implement that for qemu too. Reported-by: Waldemar Brodkorb Signed-off-by: Stafford Horne --- target/openrisc/helper.h | 1 + target/openrisc/sys_helper.c | 17 + target/openrisc/translate.c