Re: [Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-25 Thread Igor Mammedov
On Fri, 22 Jul 2016 17:46:40 -0300 Eduardo Habkost wrote: > On Fri, Jul 22, 2016 at 11:32:48AM +1000, David Gibson wrote: > > On Thu, Jul 21, 2016 at 05:54:33PM +0200, Igor Mammedov wrote: > > > Instead use QTAIL's tqe_prev field to detect if cpu's been > > > placed in list by cpu_exec_init() w

Re: [Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-22 Thread Eduardo Habkost
On Fri, Jul 22, 2016 at 11:32:48AM +1000, David Gibson wrote: > On Thu, Jul 21, 2016 at 05:54:33PM +0200, Igor Mammedov wrote: > > Instead use QTAIL's tqe_prev field to detect if cpu's been > > placed in list by cpu_exec_init() which is always set if > > QTAIL element is in list. > > > > Fixes SIG

Re: [Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-21 Thread David Gibson
On Thu, Jul 21, 2016 at 05:54:33PM +0200, Igor Mammedov wrote: > Instead use QTAIL's tqe_prev field to detect if cpu's been > placed in list by cpu_exec_init() which is always set if > QTAIL element is in list. > > Fixes SIGSEGV on failure path in case cpu_index is assigned > by board and cpu.rela

[Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu

2016-07-21 Thread Igor Mammedov
Instead use QTAIL's tqe_prev field to detect if cpu's been placed in list by cpu_exec_init() which is always set if QTAIL element is in list. Fixes SIGSEGV on failure path in case cpu_index is assigned by board and cpu.relalize() fails before cpu_exec_init() is called. In follow up patches, cpu_i