Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

2016-01-11 Thread Cédric Le Goater
On 01/08/2016 09:23 PM, Corey Minyard wrote: > Acked-by: Corey Minyard > > I agree with Greg's comments, too. Me also. I will rework the code to use ARRAY_SIZE or something similar. Thanks, C. > -corey > > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >>

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

2016-01-08 Thread Corey Minyard
Acked-by: Corey Minyard I agree with Greg's comments, too. -corey On 01/05/2016 11:29 AM, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 51 -- 1 file changed, 49

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

2016-01-06 Thread Greg Kurz
On Tue, 5 Jan 2016 18:29:56 +0100 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- Acked-by: Greg Kurz Just some minor comments on the form below. > hw/ipmi/ipmi_bmc_sim.c | 51 >

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

2016-01-06 Thread Cédric Le Goater
On 01/06/2016 10:55 AM, Greg Kurz wrote: > On Tue, 5 Jan 2016 18:29:56 +0100 > Cédric Le Goater wrote: > >> Signed-off-by: Cédric Le Goater >> --- > > Acked-by: Greg Kurz > > Just some minor comments on the form below. > > >>

[Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

2016-01-05 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ipmi/ipmi_bmc_sim.c | 51 -- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c index 559e1398d669..061db8437479 100644 ---