[Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-14 Thread Denis V. Lunev
'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration internals. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Mar

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-22 Thread Denis V. Lunev
On 01/19/2016 09:11 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-22 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 01/19/2016 09:11 PM, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: > 'name' attribute is made mandatory in distinction with HMP command. > > The patch also

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-22 Thread Denis V. Lunev
On 01/22/2016 06:31 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 01/19/2016 09:11 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: 'name' attribute is made mandatory in distinction with HMP comma

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-26 Thread Peter Krempa
On Tue, Jan 19, 2016 at 19:11:05 +0100, Markus Armbruster wrote: > "Denis V. Lunev" writes: > > > On 01/18/2016 06:58 PM, Markus Armbruster wrote: > >> "Denis V. Lunev" writes: ... > > The overloaded interface you propose is more complex than it seems. You > hide the complexity by not docume

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-26 Thread Peter Krempa
On Fri, Jan 22, 2016 at 16:31:04 +0100, Markus Armbruster wrote: > "Denis V. Lunev" writes: > > On 01/19/2016 09:11 PM, Markus Armbruster wrote: > >> "Denis V. Lunev" writes: [...] > >> This would be like HMP savevm with the following differences: > >> > >> * Separate parameters for tag and ID.

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-18 Thread Markus Armbruster
"Denis V. Lunev" writes: > 'name' attribute is made mandatory in distinction with HMP command. > > The patch also moves hmp_savevm implementation into hmp.c. This function > is just a simple wrapper now and does not have knowledge about > migration internals. > > Signed-off-by: Denis V. Lunev >

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-18 Thread Denis V. Lunev
On 01/18/2016 06:58 PM, Markus Armbruster wrote: "Denis V. Lunev" writes: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about migration inter

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

2016-01-19 Thread Markus Armbruster
"Denis V. Lunev" writes: > On 01/18/2016 06:58 PM, Markus Armbruster wrote: >> "Denis V. Lunev" writes: >> >>> 'name' attribute is made mandatory in distinction with HMP command. >>> >>> The patch also moves hmp_savevm implementation into hmp.c. This function >>> is just a simple wrapper now and