[Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-14 Thread Amit Shah
This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The virtio console is now a very simple qdev device that sits on the virtio-serial-bus and communicates

[Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-06 Thread Amit Shah
This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The virtio console is now a very simple qdev device that sits on the virtio-serial-bus and communicates

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Anthony Liguori
On 01/04/2010 11:34 AM, Amit Shah wrote: This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The virtio console is now a very simple qdev device that sits

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Amit Shah
Hey Anthony [skipping the part Gerd already answered] On (Tue) Jan 05 2010 [10:42:39], Anthony Liguori wrote: +static size_t send_control_msg(VirtIOSerialPort *port, void *buf, size_t len) +{ +VirtQueueElement elem; +VirtQueue *vq; +struct virtio_console_control *cpkt; + +

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Anthony Liguori
On 01/05/2010 11:16 AM, Amit Shah wrote: +static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent) +{ +VirtIOSerialDevice *dev = DO_UPCAST(VirtIOSerialDevice, qdev, qdev); +VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev,dev-qdev); + +

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Anthony Liguori
On 01/05/2010 11:04 AM, Gerd Hoffmann wrote: Hi, - .driver = virtio-console-pci, + .driver = virtio-serial-pci, I don't think we can eliminate the virtio-console-pci device name. If someone used -writeconfig and -virtconsole in 0.12, this change would break their written config files. It

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Gerd Hoffmann
Hi, - .driver = virtio-console-pci, + .driver = virtio-serial-pci, I don't think we can eliminate the virtio-console-pci device name. If someone used -writeconfig and -virtconsole in 0.12, this change would break their written config files. It wouldn't. virtio-console-pci was never fully

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Amit Shah
On (Mon) Jan 04 2010 [14:46:58], Anthony Liguori wrote: I'll annotate and read/write using the le format. Just use ldl_p and stl_p. (or ldw/stw as appropriate). OK, I've switched to ldl/stl. I'll send out the new series once the one I posted yesterday gets some time on the list. +static

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-05 Thread Anthony Liguori
On 12/23/2009 11:25 PM, Amit Shah wrote: On (Wed) Dec 23 2009 [17:12:22], Anthony Liguori wrote: +struct VirtIOSerial { +VirtIODevice vdev; + +VirtQueue *c_ivq, *c_ovq; +/* Arrays of ivqs and ovqs: one per port */ +VirtQueue **ivqs, **ovqs; + +VirtIOSerialBus *bus; + +

[Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2010-01-04 Thread Amit Shah
This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The virtio console is now a very simple qdev device that sits on the virtio-serial-bus and communicates

[Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2009-12-23 Thread Amit Shah
This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The virtio console is now a very simple qdev device that sits on the virtio-serial-bus and communicates

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2009-12-23 Thread Anthony Liguori
On 12/23/2009 01:52 PM, Amit Shah wrote: This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The virtio console is now a very simple qdev device that sits

Re: [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus

2009-12-23 Thread Amit Shah
On (Wed) Dec 23 2009 [17:12:22], Anthony Liguori wrote: On 12/23/2009 01:52 PM, Amit Shah wrote: This commit converts the virtio-console device to create a new virtio-serial bus that can host console and generic serial ports. The file hosting this code is now called virtio-serial-bus.c. The