Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-22 Thread Alexander Graf
> Am 22.05.2014 um 05:59 schrieb Alexey Kardashevskiy : > >> On 05/21/2014 11:23 PM, Alexander Graf wrote: >> >>> On 21.05.14 14:30, Alexey Kardashevskiy wrote: On 05/21/2014 08:44 PM, Alexander Graf wrote: > On 21.05.14 08:20, Alexey Kardashevskiy wrote: > This moves SPR initializ

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 11:23 PM, Alexander Graf wrote: > > On 21.05.14 14:30, Alexey Kardashevskiy wrote: >> On 05/21/2014 08:44 PM, Alexander Graf wrote: >>> On 21.05.14 08:20, Alexey Kardashevskiy wrote: This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexander Graf
On 21.05.14 14:30, Alexey Kardashevskiy wrote: On 05/21/2014 08:44 PM, Alexander Graf wrote: On 21.05.14 08:20, Alexey Kardashevskiy wrote: This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy I like the idea, but please refactor all book3s CPUs, not just P

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 08:44 PM, Alexander Graf wrote: > > On 21.05.14 08:20, Alexey Kardashevskiy wrote: >> This moves SPR initialization to helper functions. >> >> Signed-off-by: Alexey Kardashevskiy > > I like the idea, but please refactor all book3s CPUs, not just POWER7. > > I also think we can cove

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexander Graf
On 21.05.14 08:20, Alexey Kardashevskiy wrote: This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy I like the idea, but please refactor all book3s CPUs, not just POWER7. I also think we can cover a lot of the SPR registration by matching on feature fields

[Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-20 Thread Alexey Kardashevskiy
This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy --- target-ppc/translate_init.c | 83 + 1 file changed, 62 insertions(+), 21 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c ind