Re: [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments

2015-08-24 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2015 02:18 AM, Markus Armbruster wrote: >> A command's or event's 'data' must be a struct type, given either as a >> dictionary, or as struct type name. >> >> Commit dd883c6 tightened the checking there, but not enough: we still >> accept 'union'. Fix to reject it.

Re: [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments

2015-08-18 Thread Eric Blake
On 08/04/2015 02:18 AM, Markus Armbruster wrote: > A command's or event's 'data' must be a struct type, given either as a > dictionary, or as struct type name. > > Commit dd883c6 tightened the checking there, but not enough: we still > accept 'union'. Fix to reject it. > > We may want to support

Re: [Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments

2015-08-04 Thread Eric Blake
On 08/04/2015 03:18 AM, Markus Armbruster wrote: > A command's or event's 'data' must be a struct type, given either as a > dictionary, or as struct type name. > > Commit dd883c6 tightened the checking there, but not enough: we still > accept 'union'. Fix to reject it. > > We may want to support

[Qemu-devel] [PATCH 20/26] qapi: Fix to reject union command and event arguments

2015-08-04 Thread Markus Armbruster
A command's or event's 'data' must be a struct type, given either as a dictionary, or as struct type name. Commit dd883c6 tightened the checking there, but not enough: we still accept 'union'. Fix to reject it. We may want to support union types there, but we'll have to extend qapi-commands.py a