Re: [Qemu-devel] [PATCH 20/32] monitor: Peel off @mon_global wrapper

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Wrapping global variables in a struct without a use for the wrapper struct buys us nothing but longer lines. Unwrap them. Well, it also makes it slightly more obvious where you are using a global variable, and thus need to be careful of reentra

[Qemu-devel] [PATCH 20/32] monitor: Peel off @mon_global wrapper

2018-07-02 Thread Markus Armbruster
Wrapping global variables in a struct without a use for the wrapper struct buys us nothing but longer lines. Unwrap them. Signed-off-by: Markus Armbruster --- monitor.c | 60 +++ 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/