Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-02-03 Thread Gerd Hoffmann
Hi, > >> It looks like doing it right for relative is easy: > > > > But what is the point when this isn't used anyway? > > In what sense it is not used? Old code is obviously broken for the relative case. Seems to be used by hw/arm/spitz.c, which probably emulates a absolute pointing device.

Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-02-03 Thread Paolo Bonzini
Il 03/02/2014 10:42, Gerd Hoffmann ha scritto: Hi, +switch (graphic_rotate) { +case 90: +if (evt->abs->axis == INPUT_AXIS_X) { +evt->abs->axis = INPUT_AXIS_Y; +} +if (evt->abs->axis == INPUT_AXIS_Y) { Need else here, same for "case 270". Why?

Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-02-03 Thread Gerd Hoffmann
Hi, > > +switch (graphic_rotate) { > > +case 90: > > +if (evt->abs->axis == INPUT_AXIS_X) { > > +evt->abs->axis = INPUT_AXIS_Y; > > +} > > +if (evt->abs->axis == INPUT_AXIS_Y) { > > Need else here, same for "case 270". Why? > > +evt->abs

Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-01-31 Thread Paolo Bonzini
Il 28/01/2014 10:57, Gerd Hoffmann ha scritto: Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --

[Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-01-28 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --- ui/input.c | 33 ++

[Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2013-12-16 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --- ui/input.c | 33 ++