Re: [Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2017-01-31 Thread Max Reitz
On 01.02.2017 00:00, Max Reitz wrote: > On 31.01.2017 17:03, Vladimir Sementsov-Ogievskiy wrote: [...] >> I've started to rewrite it in that way and it seems like deep almost >> always will be false. What about just move call to >> bs->drv->bdrv_remove_persistent_dirty_bitmap() directly to >> qmp

Re: [Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2017-01-31 Thread Max Reitz
On 31.01.2017 17:03, Vladimir Sementsov-Ogievskiy wrote: > 29.01.2017 19:54, Max Reitz wrote: >> On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: >>> Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> bl

Re: [Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2017-01-31 Thread Vladimir Sementsov-Ogievskiy
29.01.2017 19:54, Max Reitz wrote: On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 21 ++--- include/block/block_int.h

Re: [Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2017-01-29 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 21 ++--- > include/block/block_int.h | 3 +++ > 2 files changed

[Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2017-01-23 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 21 ++--- include/block/block_int.h | 3 +++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/block/dirty-bitmap.c b

[Qemu-devel] [PATCH 22/24] block/dirty-bitmap: deep release dirty bitmaps

2016-12-21 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from its storage on bdrv_release_dirty_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 21 ++--- include/block/block_int.h | 3 +++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/block/dirty-bitmap.c b