Re: [Qemu-devel] [PATCH 22/38] ivshmem: Plug leaks on unplug, fix peer disconnect

2016-03-02 Thread Marc-André Lureau
On Wed, Mar 2, 2016 at 8:19 PM, Markus Armbruster wrote: > When called from process_msg_disconnect(): invalid as long as > ivshmem-spec.txt doesn't assign a sane meaning to it. Let's make it an > error there, okay? Sounds find to me too thanks -- Marc-André Lureau

Re: [Qemu-devel] [PATCH 22/38] ivshmem: Plug leaks on unplug, fix peer disconnect

2016-03-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: >> close_peer_eventfds() cleans up three things: ioeventfd triggers if >> they exist, eventfds, and the array to store them. >> >> Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers >> w

Re: [Qemu-devel] [PATCH 22/38] ivshmem: Plug leaks on unplug, fix peer disconnect

2016-03-02 Thread Marc-André Lureau
Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > close_peer_eventfds() cleans up three things: ioeventfd triggers if > they exist, eventfds, and the array to store them. > > Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers > when they don't exist (property ioevent

[Qemu-devel] [PATCH 22/38] ivshmem: Plug leaks on unplug, fix peer disconnect

2016-02-29 Thread Markus Armbruster
close_peer_eventfds() cleans up three things: ioeventfd triggers if they exist, eventfds, and the array to store them. Commit 98609cd (v1.2.0) fixed it not to clean up ioeventfd triggers when they don't exist (property ioeventfd=off, which is the default). Unfortunately, the fix also made it skip