Re: [Qemu-devel] [PATCH 24/55] ide/atapi: Track tray locked state

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:58PM +0200, Markus Armbruster wrote: We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster arm...@redhat.com Looks good,

[Qemu-devel] [PATCH 24/55] ide/atapi: Track tray locked state

2011-07-20 Thread Markus Armbruster
We already track it in BlockDriverState. Just like tray open/close state, we should track it in the device models instead, because it's device state. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/atapi.c|1 + hw/ide/internal.h |1 + 2 files changed, 2 insertions(+),