Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

2011-10-17 Thread Anthony Liguori
On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed

Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

2011-10-17 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we

Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

2011-10-17 Thread Anthony Liguori
On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed

Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

2011-10-17 Thread Anthony Liguori
On 10/17/2011 10:12 AM, Juan Quintela wrote: Anthony Liguorianth...@codemonkey.ws wrote: On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is

[Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

2011-10-11 Thread Juan Quintela
We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed migration (it can't be a sucessful one, otherwise