Re: [Qemu-devel] [PATCH 26/31] tpm: Clean up error reporting in tpm_init_tpmdev()

2018-10-10 Thread Stefan Berger
On 10/8/18 1:31 PM, Markus Armbruster wrote: Calling error_report() in a function that takes an Error ** argument is suspicious. tpm_init_tpmdev() does that, and then fails without setting an error. Its caller main(), via tpm_init() and qemu_opts_foreach(), is fine with it, but clean it up anyw

Re: [Qemu-devel] [PATCH 26/31] tpm: Clean up error reporting in tpm_init_tpmdev()

2018-10-09 Thread Marc-André Lureau
Hi On Mon, Oct 8, 2018 at 9:33 PM Markus Armbruster wrote: > > Calling error_report() in a function that takes an Error ** argument > is suspicious. tpm_init_tpmdev() does that, and then fails without > setting an error. Its caller main(), via tpm_init() and > qemu_opts_foreach(), is fine with

Re: [Qemu-devel] [PATCH 26/31] tpm: Clean up error reporting in tpm_init_tpmdev()

2018-10-09 Thread Philippe Mathieu-Daudé
On 08/10/2018 19:31, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. tpm_init_tpmdev() does that, and then fails without > setting an error. Its caller main(), via tpm_init() and > qemu_opts_foreach(), is fine with it, but clean it

[Qemu-devel] [PATCH 26/31] tpm: Clean up error reporting in tpm_init_tpmdev()

2018-10-08 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. tpm_init_tpmdev() does that, and then fails without setting an error. Its caller main(), via tpm_init() and qemu_opts_foreach(), is fine with it, but clean it up anyway. Cc: Stefan Berger Signed-off-by: Markus A