Re: [Qemu-devel] [PATCH 26/38] ivshmem: Drop the hackish test for UNIX domain chardev

2016-03-02 Thread Marc-André Lureau
Hi On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster wrote: > The chardev must be capable of transmitting SCM_RIGHTS ancillary > messages. We check it by comparing CharDriverState member filename to > "unix:". That's almost as brittle as it is disgusting. > > When the actual transmission all h

[Qemu-devel] [PATCH 26/38] ivshmem: Drop the hackish test for UNIX domain chardev

2016-02-29 Thread Markus Armbruster
The chardev must be capable of transmitting SCM_RIGHTS ancillary messages. We check it by comparing CharDriverState member filename to "unix:". That's almost as brittle as it is disgusting. When the actual transmission all happened asynchronously, this check was all we could do in realize(), and