Re: [Qemu-devel] [PATCH 28/31] target/s390x: Use unwind data for helper_lra

2017-05-23 Thread Richard Henderson
On 05/23/2017 05:11 AM, Aurelien Jarno wrote: On 2017-05-22 20:03, Richard Henderson wrote: Note that exception_index is not live during a TB, so there is no point saving it around mmu_translate. What do you mean by "is not live"? Indeed cpu_loop_exit() is not called so the TB is not

Re: [Qemu-devel] [PATCH 28/31] target/s390x: Use unwind data for helper_lra

2017-05-23 Thread Aurelien Jarno
On 2017-05-22 20:03, Richard Henderson wrote: > Note that exception_index is not live during a TB, > so there is no point saving it around mmu_translate. What do you mean by "is not live"? Indeed cpu_loop_exit() is not called so the TB is not terminated immediately. That said the while loop in

[Qemu-devel] [PATCH 28/31] target/s390x: Use unwind data for helper_lra

2017-05-22 Thread Richard Henderson
Note that exception_index is not live during a TB, so there is no point saving it around mmu_translate. Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 4 +--- target/s390x/translate.c | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git