Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-11-27 Thread Richard Henderson
On 11/27/2013 12:56 AM, Claudio Fontana wrote: > On 09/27/2013 09:42 PM, Richard Henderson wrote: >> On 09/26/2013 05:48 PM, Alexander Graf wrote: >>> +if (setflags) { >>> +tcg_dst = cpu_reg(dest); >>> +} else { >>> +tcg_dst = cpu_reg_sp(dest); >>> +} >> >> Never sp for

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-11-26 Thread Laurent Desnogues
On Tue, Nov 26, 2013 at 12:56 PM, Claudio Fontana wrote: > On 09/27/2013 09:42 PM, Richard Henderson wrote: >> On 09/26/2013 05:48 PM, Alexander Graf wrote: >>> +if (setflags) { >>> +tcg_dst = cpu_reg(dest); >>> +} else { >>> +tcg_dst = cpu_reg_sp(dest); >>> +} >> >> Ne

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-11-26 Thread Claudio Fontana
On 09/27/2013 09:42 PM, Richard Henderson wrote: > On 09/26/2013 05:48 PM, Alexander Graf wrote: >> +if (setflags) { >> +tcg_dst = cpu_reg(dest); >> +} else { >> +tcg_dst = cpu_reg_sp(dest); >> +} > > Never sp for logicals. This should be ok in my view, the manual expl

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +if (setflags) { > +tcg_dst = cpu_reg(dest); > +} else { > +tcg_dst = cpu_reg_sp(dest); > +} Never sp for logicals. > +handle_orri(s, insn); And yet again, a better function name. r~

[Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-09-26 Thread Alexander Graf
This patch adds emulation support for the orr immediate instruction family with all its implementations (and, or, xor). Signed-off-by: Alexander Graf --- target-arm/translate-a64.c | 96 +- 1 file changed, 95 insertions(+), 1 deletion(-) diff --git a/