Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-31 Thread Kevin Wolf
Am 30.05.2011 16:49, schrieb Markus Armbruster: Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 28 May 2011 09:58:24 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: diff --git a/block.h b/block.h index 1f58eab..e4053dd 100644 ---

Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-31 Thread Luiz Capitulino
On Tue, 31 May 2011 10:12:17 +0200 Kevin Wolf kw...@redhat.com wrote: Am 30.05.2011 16:49, schrieb Markus Armbruster: Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 28 May 2011 09:58:24 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com

Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-31 Thread Anthony Liguori
On 05/31/2011 08:35 AM, Luiz Capitulino wrote: On Tue, 31 May 2011 10:12:17 +0200 Do we break anything if we make eject really eject the medium (we have a virtual tray status now) instead of just closing the image? I don't think so. I guess users/clients really have the expectation that the

Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-30 Thread Luiz Capitulino
On Sat, 28 May 2011 09:58:24 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Conforms to the event specification defined in the QMP/qmp-events.txt file. I'd squash PATCH 2+3. I agree this would be more logical, but people have complained

Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-30 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 28 May 2011 09:58:24 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Conforms to the event specification defined in the QMP/qmp-events.txt file. I'd squash PATCH 2+3. I agree this

Re: [Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-28 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Conforms to the event specification defined in the QMP/qmp-events.txt file. I'd squash PATCH 2+3. Please, note the following details: o The event should be emitted only by devices which support the eject operation, which currently are:

[Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-05-27 Thread Luiz Capitulino
Conforms to the event specification defined in the QMP/qmp-events.txt file. Please, note the following details: o The event should be emitted only by devices which support the eject operation, which currently are: CDROMs (IDE and SCSI) and floppies o Human monitor commands eject and

[Qemu-devel] [PATCH 3/3] QMP: Introduce the BLOCK_MEDIA_EJECT event

2011-01-12 Thread Luiz Capitulino
Conforms to the event specification defined in the QMP/qmp-events.txt file. Please, note the following (very important) details: o The event should be emitted only by devices which support the eject operation, which (afaik) are: CDROMs (IDE and SCSI) and floppies o Human monitor