On 06/23/2017 02:25 PM, Eduardo Habkost wrote:
> On Fri, Jun 23, 2017 at 01:45:57PM -0300, Philippe Mathieu-Daudé wrote:
>> then abort calling error_setg()
>
> I don't understand the reasons for this. This commit message says
> "what" and "how", but not "why".
>
>> -assert(n >= 0 && n < gpi
On Fri, Jun 23, 2017 at 01:45:57PM -0300, Philippe Mathieu-Daudé wrote:
> then abort calling error_setg()
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/core/qdev.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 849952
On Fri, Jun 23, 2017 at 01:45:57PM -0300, Philippe Mathieu-Daudé wrote:
> then abort calling error_setg()
I don't understand the reasons for this. This commit message says
"what" and "how", but not "why".
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/core/qdev.c | 6 +-
> 1 file ch
On Fri, Jun 23, 2017 at 9:45 AM, Philippe Mathieu-Daudé wrote:
> then abort calling error_setg()
The commit message should be able to be read separately from the title.
Once you fix up the message:
Reviewed-by: Alistair Francis
Thanks,
Alistair
>
> Signed-off-by: Philippe Mathieu-Daudé
> --
then abort calling error_setg()
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/qdev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 849952a8d4..05aaa67cb8 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -448,7 +448,11 @@ qem
