Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-19 Thread Peter Lieven
On 11.03.2013 11:16, Paolo Bonzini wrote: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also flush all I/O, but double check in case iscsi_truncate() is called from

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 08:29, Peter Lieven ha scritto: On 11.03.2013 11:16, Paolo Bonzini wrote: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also flush all I/O, but double check

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-13 Thread Kevin Wolf
Am 11.03.2013 um 12:52 hat Peter Lieven geschrieben: On 11.03.2013 12:44, Paolo Bonzini wrote: Il 11/03/2013 11:19, Peter Lieven ha scritto: Am 11.03.2013 um 11:16 schrieb Paolo Bonzini pbonz...@redhat.com: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 10:31, Kevin Wolf ha scritto: Isn't the real problem that I/O requests for _this_specific_ iscsi BDS must not be in flight? So what you reall need is bdrv_drain(iscsi_bs)? If I understand the code correctly, this boils down to: while (iscsi_process_flush(iscsilun)) {

[Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-11 Thread Peter Lieven
ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also flush all I/O, but double check in case iscsi_truncate() is called from elsewhere in the future. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |4

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also flush all I/O, but double check in case iscsi_truncate() is called from elsewhere in the future. Signed-off-by:

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-11 Thread Peter Lieven
Am 11.03.2013 um 11:16 schrieb Paolo Bonzini pbonz...@redhat.com: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also flush all I/O, but double check in case

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 11:19, Peter Lieven ha scritto: Am 11.03.2013 um 11:16 schrieb Paolo Bonzini pbonz...@redhat.com: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the block_resize monitor command will also

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-11 Thread Peter Lieven
On 11.03.2013 12:44, Paolo Bonzini wrote: Il 11/03/2013 11:19, Peter Lieven ha scritto: Am 11.03.2013 um 11:16 schrieb Paolo Bonzini pbonz...@redhat.com: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending I/Os before calling the sync readcapacity commands. the

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 12:52, Peter Lieven ha scritto: For example, qcow1 (and VHDX) will already call it, but that's a bug and should be fixed otherwise. Your patch will just cause an assertion failure. In which case can qcow1 (and VHDX) be used in conjunction with an iSCSI Target? No. It is a